mihaibudiu commented on code in PR #4620:
URL: https://github.com/apache/calcite/pull/4620#discussion_r2499849453
##########
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##########
@@ -1657,11 +1657,11 @@ cross join lateral (
<![CDATA[
LogicalDelta
LogicalProject(ROWTIME=[$0], PRODUCTID=[$1], ORDERID=[$2], PRODUCTID0=[$3],
NAME=[$4], SUPPLIERID=[$5], SYS_START=[$6], SYS_END=[$7],
SYS_START_LOCAL_TIMESTAMP=[$8], SYS_END_LOCAL_TIMESTAMP=[$9])
- LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{0, 1}])
+ LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{1}])
LogicalTableScan(table=[[CATALOG, SALES, ORDERS]])
LogicalProject(PRODUCTID=[$0], NAME=[$1], SUPPLIERID=[$2],
SYS_START=[$3], SYS_END=[$4], SYS_START_LOCAL_TIMESTAMP=[$5],
SYS_END_LOCAL_TIMESTAMP=[$6])
LogicalFilter(condition=[=($cor1.PRODUCTID, $0)])
- LogicalSnapshot(period=[$cor1.ROWTIME])
+ LogicalSnapshot(period=[$cor0.ROWTIME])
Review Comment:
this seems wrong, there is no cor0 introduced
##########
core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml:
##########
@@ -373,7 +371,6 @@ TableScan:[[PROPERTIES inheritPath:[] options:{K1=v1,
K2=v2}], [PROPERTIES inher
<Resource name="hints">
<![CDATA[
Project:[[FAST_SNAPSHOT inheritPath:[] options:[PRODUCTS_TEMPORAL]]]
-Snapshot:[[FAST_SNAPSHOT inheritPath:[0, 1] options:[PRODUCTS_TEMPORAL]]]
Review Comment:
do we know what this change means?
##########
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##########
@@ -1657,11 +1657,11 @@ cross join lateral (
<![CDATA[
LogicalDelta
LogicalProject(ROWTIME=[$0], PRODUCTID=[$1], ORDERID=[$2], PRODUCTID0=[$3],
NAME=[$4], SUPPLIERID=[$5], SYS_START=[$6], SYS_END=[$7],
SYS_START_LOCAL_TIMESTAMP=[$8], SYS_END_LOCAL_TIMESTAMP=[$9])
- LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{0, 1}])
+ LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{1}])
LogicalTableScan(table=[[CATALOG, SALES, ORDERS]])
LogicalProject(PRODUCTID=[$0], NAME=[$1], SUPPLIERID=[$2],
SYS_START=[$3], SYS_END=[$4], SYS_START_LOCAL_TIMESTAMP=[$5],
SYS_END_LOCAL_TIMESTAMP=[$6])
LogicalFilter(condition=[=($cor1.PRODUCTID, $0)])
- LogicalSnapshot(period=[$cor1.ROWTIME])
+ LogicalSnapshot(period=[$cor0.ROWTIME])
Review Comment:
I suspect this signals a bug in some other place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
