dssysolyatin commented on code in PR #4620:
URL: https://github.com/apache/calcite/pull/4620#discussion_r2508081273
##########
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##########
@@ -1657,11 +1657,11 @@ cross join lateral (
<![CDATA[
LogicalDelta
LogicalProject(ROWTIME=[$0], PRODUCTID=[$1], ORDERID=[$2], PRODUCTID0=[$3],
NAME=[$4], SUPPLIERID=[$5], SYS_START=[$6], SYS_END=[$7],
SYS_START_LOCAL_TIMESTAMP=[$8], SYS_END_LOCAL_TIMESTAMP=[$9])
- LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{0, 1}])
+ LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{1}])
LogicalTableScan(table=[[CATALOG, SALES, ORDERS]])
LogicalProject(PRODUCTID=[$0], NAME=[$1], SUPPLIERID=[$2],
SYS_START=[$3], SYS_END=[$4], SYS_START_LOCAL_TIMESTAMP=[$5],
SYS_END_LOCAL_TIMESTAMP=[$6])
LogicalFilter(condition=[=($cor1.PRODUCTID, $0)])
- LogicalSnapshot(period=[$cor1.ROWTIME])
+ LogicalSnapshot(period=[$cor0.ROWTIME])
Review Comment:
Add a visit method for `LogicalSnapshot` in `RelHomogeneousShuttle`. This
should fix the issue. I don’t like how `RelHomogeneousShuttle` is implemented,
it’s too easy to break something if you forget to add the same method inside it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
