xuzifu666 commented on code in PR #4620:
URL: https://github.com/apache/calcite/pull/4620#discussion_r2513256828
##########
core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml:
##########
@@ -373,7 +371,6 @@ TableScan:[[PROPERTIES inheritPath:[] options:{K1=v1,
K2=v2}], [PROPERTIES inher
<Resource name="hints">
<![CDATA[
Project:[[FAST_SNAPSHOT inheritPath:[] options:[PRODUCTS_TEMPORAL]]]
-Snapshot:[[FAST_SNAPSHOT inheritPath:[0, 1] options:[PRODUCTS_TEMPORAL]]]
Review Comment:
```select /*+ fast_snapshot(products_temporal) */ stream * from
orders join products_temporal for system_time as of timestamp '2022-08-11
15:00:00'
on orders.productid = products_temporal.productid
This SQL is streaming SQL and is generally used in lookup join dynamic
tables, such as FlinkSQL. So my understanding is that once Snapshot in
RelShuttle is supported, there is no need for a separate stage to execute the
snapshot, so the plan here is reduced by one line. What do you think about
this? @mihaibudiu @dssysolyatin
##########
core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml:
##########
@@ -373,7 +371,6 @@ TableScan:[[PROPERTIES inheritPath:[] options:{K1=v1,
K2=v2}], [PROPERTIES inher
<Resource name="hints">
<![CDATA[
Project:[[FAST_SNAPSHOT inheritPath:[] options:[PRODUCTS_TEMPORAL]]]
-Snapshot:[[FAST_SNAPSHOT inheritPath:[0, 1] options:[PRODUCTS_TEMPORAL]]]
Review Comment:
```select /*+ fast_snapshot(products_temporal) */ stream * from
orders join products_temporal for system_time as of timestamp '2022-08-11
15:00:00'
on orders.productid = products_temporal.productid```
This SQL is streaming SQL and is generally used in lookup join dynamic
tables, such as FlinkSQL. So my understanding is that once Snapshot in
RelShuttle is supported, there is no need for a separate stage to execute the
snapshot, so the plan here is reduced by one line. What do you think about
this? @mihaibudiu @dssysolyatin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
