xuzifu666 commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3546130193
> I’m okay to merge this PR if: > > 1 The specifications for `RelShuttle` methods will be clearly defined. Right now, it has visitors for both `org.apache.calcite.rel.core` (two of them) and `org.apache.calcite.rel.logical` (the rest). 2. The test that @xiedeyantu mentioned (which was actually a very good suggestion) is written based on this specification. > > This will help us avoid forgetting new visit methods and ensure all existing methods work correctly, so any breaking changes will happen in only one release. It doesn’t matter to me if it is a separate Jira/PR or not @dssysolyatin Okay, thanks for the suggestion. I'll create a separate Jira to follow up on this test, as some design aspects might require discussion; this would be more appropriate. So, can we handle this current issue (https://issues.apache.org/jira/browse/CALCITE-6947) according to the current approach in this PR version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
