xiedeyantu commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3546155353
Thanks for the explanation @dssysolyatin . Indeed, it's quite challenging to write a comprehensive test #4641 . I've drafted a general approach (still a rough sketch) – please feel free to review its feasibility. As you mentioned, we probably need to clarify which RelNode classes should have visit methods in RelShuttle and which shouldn't (those should be excluded in the test). I'm not sure if this type of test would be acceptable to the team. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
