xiedeyantu commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3544736138
Until we have a solid refactoring plan, I agree with adding a `visit` method as a temporary fix for the current omission. However, I saw a concern raised in the refactoring Jira ticket: the generic `visit(RelNode other)` method could mask missing specific visit methods. Can we add a test to ensure that when a new `RelNode` is added, the `shuttle` does not fall back to the generic `visit(RelNode other)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
