xiedeyantu commented on code in PR #4704:
URL: https://github.com/apache/calcite/pull/4704#discussion_r2646343055
##########
testkit/src/main/java/org/apache/calcite/test/QuidemTest.java:
##########
@@ -220,7 +226,8 @@ protected void checkRun(String path) throws Exception {
// outFile = "/home/fred/calcite/core/build/quidem/test/sql/agg.iq"
final URL inUrl = QuidemTest.class.getResource("/" + n2u(path));
inFile = Sources.of(requireNonNull(inUrl, "inUrl")).file();
- outFile = replaceDir(inFile, "resources", "quidem");
+ outFile = replaceDir(inFile, "resources", "quidem/"
Review Comment:
Now we're essentially adding a layer of class name as identifier.
Overloading might be a good approach, but it could require duplicating some
code or adding a new method, which doesn’t seem to differ much from the current
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
