silundong commented on code in PR #4704:
URL: https://github.com/apache/calcite/pull/4704#discussion_r2646399021
##########
core/src/main/java/org/apache/calcite/tools/Programs.java:
##########
@@ -425,6 +426,9 @@ private static class DecorrelateProgram implements Program {
if (config.forceDecorrelate()) {
final RelBuilder relBuilder =
RelFactories.LOGICAL_BUILDER.create(rel.getCluster(), null);
+ if (config.topDownGeneralDecorrelationEnabled()) {
Review Comment:
Perhaps we also need to adapt the Program of removing subquery. When using
the new decorrelator, We recommend using
`CoreRules.FILTER_SUB_QUERY_TO_MARK_CORRELATE` and
`CoreRules.PROJECT_SUB_QUERY_TO_MARK_CORRELATE` to remove subqueries from
Filter and Project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
