silundong commented on PR #4704: URL: https://github.com/apache/calcite/pull/4704#issuecomment-3693694707
The code looks great, I just have some questions about the quidem test: 1. We want to use the new decorrelator to cover the test cases in the current iq files. After implementing left mark join in enumerable convention, we can verify the execution results. However, many iq files (such as sub-query.iq) use `!plan` to verify the plan (the plan is based on the old decorrelator ). How should we handle these? 2. After we verify that the new decorrelator correctly covers the existing test cases, `CoreQuidemTest2` might be removed. Perhaps at that time, `CoreQuidemTest` will support a configuration similar to `set new_decorrelator`, allowing users to switch between them in the iq file. Is that the intended approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
