NobiGo commented on code in PR #4713:
URL: https://github.com/apache/calcite/pull/4713#discussion_r2654657910
##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -233,6 +233,58 @@ protected TrimResult trimChild(
return dispatchTrimFields(input, fieldsUsedBuilder.build(), extraFields);
}
+ /**
+ * Trims the fields of an input relational expression for RelNode with
multiple inputs.
+ *
+ * @param rel Relational expression
+ * @param input Input relational expression, whose fields to trim
+ * @param startIndex Start index of the field range to process
+ * @param endIndex End index of the field range to process (exclusive)
+ * @param fieldsUsed Bitmap of fields needed by the consumer
+ * @return New relational expression and its field mapping
+ */
+ protected TrimResult trimChild(
Review Comment:
Keep same as:
```
protected TrimResult trimChild(
RelNode rel,
RelNode input,
final ImmutableBitSet fieldsUsed,
Set<RelDataTypeField> extraFields)
```
Additionally, both of these methods are only called in RelFieldTrimmer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
