NobiGo commented on code in PR #4713:
URL: https://github.com/apache/calcite/pull/4713#discussion_r2654841449
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3103,12 +3103,25 @@ protected RelNode createJoin(
p.id, requiredCols, joinType);
}
- final RelNode node =
+ RelNode node =
relBuilder.push(leftRel)
.push(rightRel)
.join(joinType, joinCond)
.build();
+ final CorrelationUse correlationUseInJoin = getCorrelationUse(bb, node);
Review Comment:
In the `createJoin` function, `CorrelationUse` is checked twice: once to
determine if it references the output of the left node, and another time to
check if it references the output of the Join node. Here, it is checking the
reference to the Join node. If we use this CorrelationId as a parameter, two
parameters will be required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
