mihaibudiu commented on code in PR #4713:
URL: https://github.com/apache/calcite/pull/4713#discussion_r2654774244
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3103,12 +3103,25 @@ protected RelNode createJoin(
p.id, requiredCols, joinType);
}
- final RelNode node =
+ RelNode node =
relBuilder.push(leftRel)
.push(rightRel)
.join(joinType, joinCond)
.build();
+ final CorrelationUse correlationUseInJoin = getCorrelationUse(bb, node);
Review Comment:
it looks to me that the signature of the existing createJoin method is
incorrect - it should always take a list of correlationIds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
