mihaibudiu commented on code in PR #4725:
URL: https://github.com/apache/calcite/pull/4725#discussion_r2684144874
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -616,6 +617,42 @@ public static RelDataType createJoinType(
return typeFactory.createStructType(typeList, nameList);
}
+ /**
+ * Returns the type of mark join. Taking LEFT_MARK join as an example, its
output is all rows
+ * from the left side and creates a new attribute to mark a tuple as having
join partners from
+ * right side or not.
+ *
+ * <p> Conceptually the type of marker is a three-valued boolean, but it can
be simplified to a
Review Comment:
Frankly I don't understand how this explanation relates to the computed
output type.
If it doesn't, maybe it should be just a regular comment, not a JavaDoc
comment.
Comments explain how something is done, while JavaDoc explains what is being
done.
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -616,6 +617,42 @@ public static RelDataType createJoinType(
return typeFactory.createStructType(typeList, nameList);
}
+ /**
+ * Returns the type of mark join. Taking LEFT_MARK join as an example, its
output is all rows
Review Comment:
the type of the result collection produced by a mark join.
(There's also a joinType.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
