silundong commented on code in PR #4725:
URL: https://github.com/apache/calcite/pull/4725#discussion_r2684820667
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -616,6 +617,42 @@ public static RelDataType createJoinType(
return typeFactory.createStructType(typeList, nameList);
}
+ /**
+ * Returns the type of mark join. Taking LEFT_MARK join as an example, its
output is all rows
+ * from the left side and creates a new attribute to mark a tuple as having
join partners from
+ * right side or not.
+ *
+ * <p> Conceptually the type of marker is a three-valued boolean, but it can
be simplified to a
Review Comment:
I'll move it inside the method as a regular comment. The intention of this
comment is to explain why we don't directly set the marker's type to nullable
boolean, but instead use the type of the join condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
