mihaibudiu commented on code in PR #4725:
URL: https://github.com/apache/calcite/pull/4725#discussion_r2669831077
##########
core/src/main/java/org/apache/calcite/rel/core/Join.java:
##########
@@ -260,9 +268,20 @@ protected int deepHashCode0() {
}
@Override protected RelDataType deriveRowType() {
+ RelDataTypeFactory typeFactory = getCluster().getTypeFactory();
+ RelDataType rightType = right.getRowType();
+ if (joinType == JoinRelType.LEFT_MARK) {
Review Comment:
If the method is supposed to be called from the same places as the super
class method, overriding is the right move. A comment would be helpful about
the restricted nature of left mark joins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
