xiedeyantu commented on code in PR #4803:
URL: https://github.com/apache/calcite/pull/4803#discussion_r2958566036
##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -136,11 +139,13 @@ public class HepPlanner extends AbstractRelOptPlanner {
*
* <p>Value: match-key ID lists in {@link #firedRulesCache} that contain the
key ID.
*/
- private final Multimap<Integer, List<Integer>> firedRulesCacheIndex =
HashMultimap.create();
-
+ private final Multimap<Integer, ImmutableIntList> firedRulesCacheIndex =
HashMultimap.create();
private boolean enableFiredRulesCache = false;
+ private boolean largePlanMode = false;
Review Comment:
Thank you for the explanation. Regarding the first question, my concern is
whether a single case can effectively cover a wide range of scenarios. As for
the second question, while it is true that HepPlanner supports several
traversal strategies, I believe that the current optimization should not
interfere with these traversal methods—since they are currently supported, we
must ensure backward compatibility. If a specific traversal strategy were to be
adversely affected, shouldn't we consider disabling this optimization in such
instances? I would appreciate it if you could let me know whether my
understanding is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
