xiedeyantu commented on code in PR #4803:
URL: https://github.com/apache/calcite/pull/4803#discussion_r2963676665
##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -136,11 +139,13 @@ public class HepPlanner extends AbstractRelOptPlanner {
*
* <p>Value: match-key ID lists in {@link #firedRulesCache} that contain the
key ID.
*/
- private final Multimap<Integer, List<Integer>> firedRulesCacheIndex =
HashMultimap.create();
-
+ private final Multimap<Integer, ImmutableIntList> firedRulesCacheIndex =
HashMultimap.create();
private boolean enableFiredRulesCache = false;
+ private boolean largePlanMode = false;
Review Comment:
For the first point, I'm concerned that a one-time review of the results
doesn't establish a standardized process for future iterations. For the second
point, I want to ask whether this optimization can avoid these issues, or if it
can automatically fall back to a degraded mode with certain constraints when
users employ such methods. Is this feasible to implement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
