xiedeyantu commented on PR #4803: URL: https://github.com/apache/calcite/pull/4803#issuecomment-4103475548
Actually, my personal opinion is that we should enable this configuration by default (or perhaps we don't even need to add such a configuration), but only apply it to traversal methods that are backward compatible. If it cannot support all traversal methods, wouldn't it be better to add a configuration parameter here? Since you mentioned that this optimization is beneficial and never worse in any scenario. Although you added many tests (I'm not sure if these tests can be run successfully this way, but I assume they can), I feel it's still not enough. Perhaps we could seek opinions from @mihaibudiu and @asolimando . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
