venkata91 commented on PR #4928:
URL: https://github.com/apache/calcite/pull/4928#issuecomment-4432877725
Thanks @asolimando, @xiedeyantu, @dssysolyatin. I read through CALCITE-7288
and the prior discussion on #4620/#4641, and I understand the concern: without
a spec + test, every gap fix is a fresh breaking change for consumers with
`instanceof` workarounds.
That said, the gap isn't theoretical for my use case, the missing dispatch
produces silently incorrect runtime results in Flink's UNNEST projection
pushdown.
Two options I'd be happy to pursue, both documenting the breaking change in
the release notes following the pattern from #4620:
A. Expand this PR to cover all three rels (LogicalTableFunctionScan,
LogicalWindow, LogicalSnapshot) => the same three that
`SqlHintsConverterTest.HintCollector's` instanceof workaround targets. We can
rip the band-aid off by landing the breaking change once across all known gaps
rather than spreading it over multiple releases.
B. Keep this PR scoped to LogicalTableFunctionScan only — narrowest blast
radius, addresses the concrete bug, defers Window/Snapshot to follow-up JIRAs.
A is more efficient if we're accepting the breaking change anyway; B is
safer if we want to tackle the Window/Snapshot under the broader CALCITE-7288
effort. Either way, I'd like to keep the discussion of a long-term spec/test on
CALCITE-7288 rather than blocking this one.
What do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
