venkata91 commented on PR #4928: URL: https://github.com/apache/calcite/pull/4928#issuecomment-4433264481
> I personally would not mind implementing all of them and documenting the breaking change. That's how it's supposed to work. If the upgrade path for users is not difficult, we should describe it for users in the release notes. > > However, Calcite uses semantic versioning, so this kind of change should be officially prohibited. But I don't see any Calcite 2.0 release on the horizon, so I don't think this can be postponed indefinitely. Okay in that case, let me fix it for the other Nodes as well `LogicalWindow` and `LogicalSnapshot` and add a test to prevent it from getting missed later. But this doesn't prevent users from using `instanceof` approach later right even after we document this as a breaking change in `Release Notes`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
