mihaibudiu commented on code in PR #4912:
URL: https://github.com/apache/calcite/pull/4912#discussion_r3267875126
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7530,7 +7531,7 @@ private SqlNode expandExprFromJoin(SqlJoin join,
SqlIdentifier identifier, Selec
final SqlIdentifier exp =
new SqlIdentifier(
ImmutableList.of(child.name, name),
- identifier.getParserPosition());
+ SqlParserPos.ZERO);
Review Comment:
I don't understand. Are you saying that having position on the identifier
leads to an error, and not having one does not? I didn't know that's possible.
What is a "synthetic" identifier? In the end all identifiers come from the
source code.
Providing errors without source position is a worse user-experience, even if
the program has been optimized. Is the concern for SqlAdvisor based on a
concrete example, or is it hypothetical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
