mihaibudiu commented on code in PR #4912:
URL: https://github.com/apache/calcite/pull/4912#discussion_r3275393606
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7530,7 +7531,7 @@ private SqlNode expandExprFromJoin(SqlJoin join,
SqlIdentifier identifier, Selec
final SqlIdentifier exp =
new SqlIdentifier(
ImmutableList.of(child.name, name),
- identifier.getParserPosition());
+ SqlParserPos.ZERO);
Review Comment:
Validation errors are not the only errors we have to be concerned about.
Our compiler carries the position information all the way to the runtime,
and surfaces runtime errors using source position information. A runtime error
without position information usually provides very little actionable insight to
the user about what went wrong. So in general I am trying very hard to preserve
any source position information that is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
