sbroeder commented on code in PR #4959:
URL: https://github.com/apache/calcite/pull/4959#discussion_r3289554519
##########
core/src/main/java/org/apache/calcite/rex/RexCall.java:
##########
@@ -228,8 +228,13 @@ private boolean digestWithType() {
return operands.get(0).isAlwaysFalse();
case IS_NOT_FALSE:
case IS_TRUE:
- case CAST:
return operands.get(0).isAlwaysTrue();
+ case CAST:
Review Comment:
Great observation. I chose to use a test for BOOLEAN and return false
because I am worried about assert not firing in production code. I think this
is safe and covers the case where future cases might be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
