mihaibudiu commented on code in PR #4959:
URL: https://github.com/apache/calcite/pull/4959#discussion_r3289889112
##########
core/src/main/java/org/apache/calcite/rex/RexCall.java:
##########
@@ -228,8 +228,13 @@ private boolean digestWithType() {
return operands.get(0).isAlwaysFalse();
case IS_NOT_FALSE:
case IS_TRUE:
- case CAST:
return operands.get(0).isAlwaysTrue();
+ case CAST:
Review Comment:
If it's a bug to call this function with non-boolean expressions, it should
be an assert or an explicit exception; by returning early you are hiding the
bug.
Unfortunately there is no JavaDoc telling us what the precondtions are. I
personally prefer as many assertions as possible, to find bugs early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
