mihaibudiu commented on code in PR #4959:
URL: https://github.com/apache/calcite/pull/4959#discussion_r3292161221
##########
core/src/main/java/org/apache/calcite/rex/RexCall.java:
##########
@@ -228,8 +228,13 @@ private boolean digestWithType() {
return operands.get(0).isAlwaysFalse();
case IS_NOT_FALSE:
case IS_TRUE:
- case CAST:
return operands.get(0).isAlwaysTrue();
+ case CAST:
Review Comment:
This is because these test which you wrote do not respect the new
precondition of the function. Do these tests correspond to a situation you have
observed in practice? If so, can you supply an end-to-end test which
illustrates this case?
If not, a solution is to simply delete these tests, since they do not
exercise a "real" possible path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
