wasabii commented on code in PR #5276:
URL: https://github.com/apache/calcite/pull/5276#discussion_r4071595368
##########
core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java:
##########
@@ -243,34 +245,54 @@ public JsonPathContext
jsonApiCommonSyntaxWithCache(String input,
SqlJsonValueEmptyOrErrorBehavior emptyBehavior,
Object defaultValueOnEmpty,
SqlJsonValueEmptyOrErrorBehavior errorBehavior,
- Object defaultValueOnError) {
+ Object defaultValueOnError,
+ SqlTypeName returningType,
Review Comment:
Yeah..... I'm going to ask for your advice on this one.
And what the breakdown would be.... I guess the bundle of new things
"returningType", "precision", "scale", "roundingMode". Could be.... a CastItem
or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]