wasabii commented on code in PR #5276:
URL: https://github.com/apache/calcite/pull/5276#discussion_r4074194791


##########
core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java:
##########
@@ -243,34 +245,54 @@ public JsonPathContext 
jsonApiCommonSyntaxWithCache(String input,
         SqlJsonValueEmptyOrErrorBehavior emptyBehavior,
         Object defaultValueOnEmpty,
         SqlJsonValueEmptyOrErrorBehavior errorBehavior,
-        Object defaultValueOnError) {
+        Object defaultValueOnError,
+        SqlTypeName returningType,

Review Comment:
   Okay. I added a new type named CastSpec. I couldn't really find any existing 
patterns for naming, etc. So, we can rename this if ya'll don't like it. But 
the idea is there. It also contains the rounding mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to