wasabii commented on code in PR #5276:
URL: https://github.com/apache/calcite/pull/5276#discussion_r4074366821
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3364,6 +3364,40 @@ static Expression call(Method method, @Nullable
Expression target,
}
}
+ /** Base class for the implementors of {@code JSON_VALUE} and
+ * {@code JSON_QUERY}. */
+ private abstract static class JsonImplementor extends MethodImplementor {
+ JsonImplementor(Method method) {
+ super(method, NullPolicy.ARG0, false);
+ }
+
+ /** Calls the runtime method with {@code operands}, followed by the
Review Comment:
I removed this method and just folded it into the general expression
emitters, now that they ended up mostly doing their work in a similar method
designed around CastSpec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
