rubenada commented on code in PR #5294:
URL: https://github.com/apache/calcite/pull/5294#discussion_r4154671866
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -3991,13 +3930,44 @@ void AddWithItem(List<SqlWithItem> list, SqlLiteral
recursive) :
final SqlIdentifier id;
final SqlNodeList columnList;
final SqlNode definition;
+ SqlCycleClause cycle = null;
}
{
id = SimpleIdentifier()
( columnList = ParenthesizedSimpleIdentifierList() | { columnList = null;
} )
<AS>
definition = ParenthesizedExpression(ExprContext.ACCEPT_QUERY)
- { list.add(new SqlWithItem(id.getParserPosition(), id, columnList,
definition, recursive)); }
+ [ cycle = CycleClause() ]
Review Comment:
I think it would be nice to add new tests around CYCLE feature in
SqlParserTest, including "wrong" queries failing with the expected error
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
