rubenada commented on code in PR #5294:
URL: https://github.com/apache/calcite/pull/5294#discussion_r4157581601
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -3991,13 +3930,44 @@ void AddWithItem(List<SqlWithItem> list, SqlLiteral
recursive) :
final SqlIdentifier id;
final SqlNodeList columnList;
final SqlNode definition;
+ SqlCycleClause cycle = null;
}
{
id = SimpleIdentifier()
( columnList = ParenthesizedSimpleIdentifierList() | { columnList = null;
} )
<AS>
definition = ParenthesizedExpression(ExprContext.ACCEPT_QUERY)
- { list.add(new SqlWithItem(id.getParserPosition(), id, columnList,
definition, recursive)); }
+ [ cycle = CycleClause() ]
Review Comment:
Thanks! Just for the sake of completeness, could you please also add some
quidem tests? e.g. inside `recursive_queries.iq` (you can take a look at the
existing tests in that file for reference)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
