vldpyatkov commented on code in PR #5294:
URL: https://github.com/apache/calcite/pull/5294#discussion_r4154637232
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/PhysTypeImpl.java:
##########
@@ -587,6 +587,11 @@ private RelDataType toStruct(RelDataType type) {
@Override public @Nullable Expression comparer() {
final Expression comparer = format.comparer();
if (comparer != null) {
+ // ARRAY compares nested arrays by content, but a List or Map compares
Review Comment:
I considered that, but ARRAY's comparator does not have access to the row
type. Switching it to the deep comparer unconditionally could add overhead for
cases the existing comparer already handles correctly.
The existing comparer already handles nested Java arrays by content. The
issue arises when a collection or map contains Object[] values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
