julianhyde commented on code in PR #5274:
URL: https://github.com/apache/calcite/pull/5274#discussion_r4159463445
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -367,15 +409,26 @@ public RelFactories.TableScanFactory getScanFactory() {
* you need to use previously built expressions as inputs, call
* {@link #build()} to pop those inputs. */
public RelBuilder push(RelNode node) {
- stack.push(new Frame(node));
+ stack.add(new Frame(node));
Review Comment:
It was my suggestion to convert `stack` from an `ArrayDeque` to a custom
queue implementation. It will allow most code to continue unchanged.
This particular line of code could and should remain `stack.push(new
Frame(node))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
