xuzifu666 commented on code in PR #5274:
URL: https://github.com/apache/calcite/pull/5274#discussion_r4194829241
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -367,15 +409,26 @@ public RelFactories.TableScanFactory getScanFactory() {
* you need to use previously built expressions as inputs, call
* {@link #build()} to pop those inputs. */
public RelBuilder push(RelNode node) {
- stack.push(new Frame(node));
+ stack.add(new Frame(node));
Review Comment:
Apologies for the delay in handling this(I was on vacation before).
Nice catch, that was unintended. All call sites are now back to the original
`stack.push()` / `stack.pop()`. `FrameStack`provides those methods( delegating
to a backing `ArrayDeque`), so no call site changes remain; the only deleted
line in `RelBuilder` is the old field declaration. cc @mihaibudiu @julianhyde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
