xuzifu666 commented on code in PR #5274:
URL: https://github.com/apache/calcite/pull/5274#discussion_r4194834644
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -195,7 +199,45 @@
public class RelBuilder {
protected final RelOptCluster cluster;
protected final @Nullable RelOptSchema relOptSchema;
- private final Deque<Frame> stack = new ArrayDeque<>();
+ /** Stack of relational expressions that are being built.
+ *
Review Comment:
Done, the anonymous class is now a named inner class, `FrameStack`, placed
at the end of the file next to `Frame`. The check still happens in `offer()`,
which `push()` delegates to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]