bvolpato commented on code in PR #5242:
URL: https://github.com/apache/calcite/pull/5242#discussion_r4223851809
##########
core/src/test/java/org/apache/calcite/runtime/EnumerablesTest.java:
##########
@@ -342,6 +351,21 @@ class EnumerablesTest {
JoinType.LEFT);
}
+ @Test void testMergeAntiJoinWithRepeatedNullKeys() {
Review Comment:
Moved both cases into the ANTI section of `testMergeJoin3` in 03486d7.
##########
core/src/test/java/org/apache/calcite/runtime/EnumerablesTest.java:
##########
@@ -342,6 +351,21 @@ class EnumerablesTest {
JoinType.LEFT);
}
+ @Test void testMergeAntiJoinWithRepeatedNullKeys() {
Review Comment:
Added a one-line comment above each case that names the path it exercises,
in 03486d7. Both cases are now in the ANTI section of `testMergeJoin3`.
##########
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##########
@@ -5125,7 +5125,7 @@ private boolean advance() {
// mergeJoin assumes inputs sorted in ascending order with nulls
last,
// if we reach a null key, we are done.
Review Comment:
Changed the comment in 03486d7. It now says that a NULL key means there are
no more matches, which is true for every join type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
