bvolpato commented on PR #5242: URL: https://github.com/apache/calcite/pull/5242#issuecomment-6068556111
Addressed the review suggestions in 03486d7. - Added `EnumerableJoinTest.testMergeJoinAntiWithSingleKeyAndNullValues`. It fails with the base `EnumerableDefaults.java` (`was "empid=100\nempid=110"`) and passes with the fix. - Moved the repeated NULL key cases into the ANTI section of `testMergeJoin3`, with a comment on each case. - Corrected the two comments in `EnumerableDefaults`. - The PR description now states that the previous ANTI expectations in `EnumerablesTest` encoded the bug. The subject of the first commit still lacks the `[CALCITE-7817]` prefix. I added a new commit instead of a force-push, to keep the review history. I can squash both commits under the PR title when the review is complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
