bvolpato commented on code in PR #5242:
URL: https://github.com/apache/calcite/pull/5242#discussion_r4223854173
##########
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##########
@@ -5234,9 +5234,10 @@ private boolean advanceLeft(TSource left, TKey leftKey) {
while (getLeftEnumerator().moveNext()) {
left = getLeftEnumerator().current();
TKey leftKey2 = outerKeySelector.apply(left);
- if (leftKey2 == null && joinType != JoinType.LEFT) {
+ if (leftKey2 == null && !isLeftOrAntiJoin()) {
Review Comment:
Corrected the `@return` in 03486d7. It now says that a NULL key ends the
loop only when the join is not LEFT or ANTI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
