squakez commented on a change in pull request #2309:
URL: https://github.com/apache/camel-k/pull/2309#discussion_r634387536
##########
File path: pkg/trait/builder.go
##########
@@ -59,7 +63,11 @@ func (t *builderTrait) Configure(e *Environment) (bool,
error) {
}
func (t *builderTrait) Apply(e *Environment) error {
- builderTask := t.builderTask(e)
+ builderTask, err := t.builderTask(e)
+ if err != nil {
+ // Should we clean the failing integration kit as well?
Review comment:
Ì have a doubt here. If the task fails (ie, a bad format property is
provided), we are safely returning and showing a log on the operator side.
However, the failing integration kit will hang around until a manual removal is
performed. I wonder if in this situation we can mark the `IntegrationKit` in
order to be cleaned. Is that possible? how to perform that? @nicolaferraro
@astefanutti do you have any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
