astefanutti commented on a change in pull request #2309:
URL: https://github.com/apache/camel-k/pull/2309#discussion_r634407932
##########
File path: pkg/trait/builder.go
##########
@@ -59,7 +63,11 @@ func (t *builderTrait) Configure(e *Environment) (bool,
error) {
}
func (t *builderTrait) Apply(e *Environment) error {
- builderTask := t.builderTask(e)
+ builderTask, err := t.builderTask(e)
+ if err != nil {
+ // Should we clean the failing integration kit as well?
Review comment:
By default, an event will be emitted:
https://github.com/apache/camel-k/blob/1b64912e2f1e67bb3dfe287d3ba65ddc5e50cf33/pkg/controller/integrationkit/integrationkit_controller.go#L252
In that case, the reconciliation request is requeued for retry. That is
applicable to general errors, that may be recoverable, such as conflicting
changes. In case of an error that we know cannot be recovered, the
IntegrationKit phase must be set to `IntegrationKitPhaseError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
