astefanutti commented on a change in pull request #2309:
URL: https://github.com/apache/camel-k/pull/2309#discussion_r634392785
##########
File path: pkg/trait/builder.go
##########
@@ -32,6 +34,8 @@ type builderTrait struct {
BaseTrait `property:",squash"`
// Enable verbose logging on build components that support it (e.g.
Kaniko build pod).
Verbose *bool `property:"verbose" json:"verbose,omitempty"`
+ // A list of properties to be provided to the build task
+ BuildTimeProperties []string `property:"build-time-properties"
json:"buildTimeProperties,omitempty"`
Review comment:
Can I suggest:
Properties []string `property:"properties" json:"properties,omitempty"`
It's quite clear in the scope of the builder trait that these properties are
applied at build time.
Or possibly:
MavenProperties []string `property:"maven-properties"
json:"mavenProperties,omitempty"`
To make it clearer that these are Maven properties.
##########
File path: pkg/trait/builder.go
##########
@@ -32,6 +34,8 @@ type builderTrait struct {
BaseTrait `property:",squash"`
// Enable verbose logging on build components that support it (e.g.
Kaniko build pod).
Verbose *bool `property:"verbose" json:"verbose,omitempty"`
+ // A list of properties to be provided to the build task
+ BuildTimeProperties []string `property:"build-time-properties"
json:"buildTimeProperties,omitempty"`
Review comment:
Can I suggest:
Properties []string `property:"properties" json:"properties,omitempty"`
It's quite clear in the scope of the builder trait that these properties are
applied at build time.
Or possibly:
MavenProperties []string `property:"maven-properties"
json:"mavenProperties,omitempty"`
To make it clearer that these are Maven properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
