davsclaus commented on PR #24863: URL: https://github.com/apache/camel/pull/24863#issuecomment-5005612842
_Claude Code on behalf of davsclaus_ @gnodet Thanks for the thorough review! Both issues are now addressed: **1. ShardIteratorHandler / PR #24861 conflict** — Rebased onto `main`. The DDB stream commit was dropped since PR #24861 already landed with a more complete implementation (paginated `DescribeStream`, defensive copy, `TRIM_HORIZON` fallback, plus `pendingClosedShards` tracking and 3 tests). No DDB stream diff remains. **2. KinesisResumeAction registry lookup** — Restored the registry lookup but fixed the thread-safety issue by creating a per-shard instance via `getDeclaredConstructor().newInstance()` from the template's class. This preserves backward compatibility for users who register custom `KinesisResumeAction` subclasses (including the `KinesisConsumerResumeIT` test pattern) while avoiding concurrent mutation of a shared singleton. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
