davsclaus commented on PR #24863:
URL: https://github.com/apache/camel/pull/24863#issuecomment-5010140998
Thanks for the thorough review @oscerd! Good catch on the resume-action
reflection contract — this was actually already addressed in commit `eb6db73`
("Fix KinesisConsumerResumeIT for per-shard resume action instances"), which:
- Changed `TestResumeAction` to use a package-private no-arg constructor
(replacing the `private TestResumeAction(int)`)
- Made `previousRecords` and `expectedCount` static volatile fields with
static setters, so reflection-created per-shard instances can share test state
That commit was pushed before your review but may not have been visible yet.
The no-arg constructor requirement for custom `RESUME_ACTION` implementations
is a valid point to document — I'll add a note about that.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
