davsclaus commented on PR #24863: URL: https://github.com/apache/camel/pull/24863#issuecomment-5007397021
_Claude Code on behalf of davsclaus_ @oscerd Thanks for the thorough review and for independently confirming the two blockers. All items are now addressed: **1. ShardIteratorHandler conflict (blocker)** — Rebased onto current `main`. The overlapping DDB stream hunks were dropped since PR #24861 already landed with the superior implementation. No `ShardIteratorHandler` diff remains. **2. KinesisResumeAction registry removal (blocker)** — Already addressed in commit `3c88130` (now `cc6b42d` after rebase). The registry lookup is preserved — `resolveResumeAction()` looks up a template via `lookupByNameAndType()`, then creates a per-shard instance via `getDeclaredConstructor().newInstance()` from the template's class, preserving custom subclass types while fixing the thread-safety issue. **3. SQS delay behavior change (minor)** — Added an upgrade guide note in `camel-4x-upgrade-guide-4_22.adoc` documenting that `delayQueue=true` and FIFO queues now skip per-message `DelaySeconds` (commit `d11dd9e`). **4. `shardClosed` `@UriParam` (minor)** — The annotation already had `defaultValue = "ignore"` on `main`; the PR only added the matching field initializer `= Kinesis2ShardClosedStrategyEnum.ignore`. Both are now consistent. **5. Missing tests (minor)** — Acknowledged. The S3, Kinesis, SNS, and SQS fixes all touch live-AWS code paths (multipart upload, shard iteration, topic creation, queue delay) that require real credentials for meaningful testing. The unit-testable DDB transformer fix does have existing test coverage via `Ddb2JsonDataTypeTransformerTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
