atiaomar1978-hub commented on PR #25203: URL: https://github.com/apache/camel/pull/25203#issuecomment-5159399112
_AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)_ ### Review follow-up (`552be2036eb`) **@gnodet** — addressed the remaining actionable code review item from the latest re-review: - **`EmbeddedMcpHttpServerTest`**: wrapped HTTP assertions in `try/finally` so `camelContext.stop()` runs even when an assertion or HTTP call fails (avoids leaking Vert.x/management server for the rest of the test JVM). Prior commits already covered AssertJ migration, expanded MCP test coverage, host/port default fix, JSON-RPC error codes, and Run.java config simplification. **Design hold (unchanged):** per @jamesnetherton / @Croway / prior thread, merge remains on hold pending CAMEL-24308 alignment on `camel.mcp.*` vs `camel.server.mcp-*`. No code change for that until committers decide on namespace/scope. **Local tests (all green — 17 total):** - `McpConfigurationPropertiesTest` (3) - `StreamableMcpJsonRpcEngineTest` (11) - `RunMcpOptionTest` (2) - `EmbeddedMcpHttpServerTest` (1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
