atiaomar1978-hub commented on PR #25203:
URL: https://github.com/apache/camel/pull/25203#issuecomment-5133322414

   _AI-generated comment on behalf of 
[atiaomar1978-hub](https://github.com/atiaomar1978-hub)_
   
   Pushed latest commit addressing @gnodet's review on [PR 
#25203](https://github.com/apache/camel/pull/25203):
   
   1. **MCP host/port defaults** — `McpConfigurationProperties` no longer 
defaults to `127.0.0.1`/`8080`; `setMcpProperties()` only propagates explicitly 
configured values so enabling MCP no longer narrows management bind from 
`0.0.0.0`. JBang `--mcp` still binds localhost via `KameletMain`.
   2. **Run.java configuration** — Removed redundant 
`writeSetting`/`configure()`/`mainListenerClasses` block; `--mcp` now follows 
the same single `writeSetting(camel.jbang.mcp)` pattern as 
`--console`/`--health`, with wiring in `KameletMain`.
   3. **JSON-RPC compliance** — Malformed JSON returns `-32700` (Parse error); 
missing `tools/call` params/name returns `-32602` (Invalid params).
   4. **Server version** — MCP `initialize` reports the Camel version from 
`camel-jbang-core` pom.properties.
   
   **Tests:** `StreamableMcpJsonRpcEngineTest` (9), `EmbeddedMcpHttpServerTest` 
(1), `RunMcpOptionTest` (1), `McpConfigurationPropertiesTest` (1) — all green 
locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to