atiaomar1978-hub commented on PR #25203: URL: https://github.com/apache/camel/pull/25203#issuecomment-5159539294
_AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)_ ### Review follow-up (`fa49389cde2`) Verified on branch `CAMEL-23853-jbang-run-mcp` — all **actionable code review items from @gnodet are already addressed** in prior commits (`552be2036eb` and earlier): - MCP host/port null defaults (no silent `0.0.0.0` → `127.0.0.1` override) - `Run.java` config simplified; listener append pattern in `KameletMain` - JSON-RPC `-32700` / `-32602` error codes; Camel version in `initialize` - AssertJ migration + expanded test coverage - `EmbeddedMcpHttpServerTest` try/finally cleanup **This push** adds two JSON-RPC edge-case tests: - unknown method → `-32601` - `ping` → empty result object **Local tests (19 total — all green):** - `McpConfigurationPropertiesTest` (3) - `StreamableMcpJsonRpcEngineTest` (13) - `RunMcpOptionTest` (2) - `EmbeddedMcpHttpServerTest` (1) **Design hold (unchanged):** per @jamesnetherton / @Croway / prior thread, merge remains on hold pending CAMEL-24308 alignment on `camel.mcp.*` vs `camel.server.mcp-*`. No further code changes until committers decide on namespace/scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
