atiaomar1978-hub commented on PR #25433: URL: https://github.com/apache/camel/pull/25433#issuecomment-5249737219
## Review feedback addressed (@davsclaus) Thanks for the thorough review! The following items have been fixed in commits `08dd1a2` and `1ddf05a`: | Severity | Issue | Fix | |----------|-------|-----| | **Blocking** | Unresolved merge conflict in `parent/pom.xml` | Conflict resolved; branch rebased on current `main` | | **Significant** | `camel-alibaba-common` depended on OSS SDK | OSS client builder moved to `OSSUtils.createClient()` in `camel-alibaba-oss`; common module now only contains `ServiceKeys` | | **Significant** | `OSSEndpoint.initClient()` didn't cache client | Client assigned to `this.ossClient`; closed in `doStop()` when not autowired | | **Significant** | `AlibabaClientRegistry` unused | Removed from common module | | **Moderate** | OSS `Content-Length`/`Content-Type` headers collide with HTTP headers | Renamed to `CamelAlibabaOssContentLength` / `CamelAlibabaOssContentType` | | **Moderate** | Missing `@Override` on `OSSComponent.createEndpoint()` | Added | | **Question** | MNS deprecation | Added NOTE in MNS docs recommending RocketMQ for greenfield projects | ### Tests (33 passing) ```bash ./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns test ``` ### Follow-ups (non-blocking, unchanged) - OSS producer JSON serialization via Gson (consider structured headers in future) - Integration tests with testcontainers - Spring Boot starters --- ## Bugbot / Grok Review **Verdict:** Approve — prior blocking/significant review items addressed. Remaining non-blocking observations: - OSS producer still serializes SDK responses to JSON (future improvement) - Switch style inconsistency between OSS/MNS (cosmetic) - Integration tests deferred to follow-up PR _AI-generated comment on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
