atiaomar1978-hub commented on PR #25433: URL: https://github.com/apache/camel/pull/25433#issuecomment-5249808289
## Bugbot / Grok follow-up (commit `15349b7`) Additional fixes pushed after automated review: | Severity | Issue | Fix | |----------|-------|-----| | Significant | OSS credential resolution ignored endpoint AK/SK when empty `ServiceKeys` bean present | Match MNS/Huawei pattern: prefer endpoint params, then non-empty `ServiceKeys` | | Significant | MNS client never closed on shutdown | Added `doStop()` + `autowiredMnsClient` flag (mirrors OSS) | | Moderate | `listObjects` ignored `maxKeys` and scanned entire bucket | Cap collected results at `maxKeys` | **Bugbot verdict:** Approve for phase 1 MVP after these commits. **Grok verdict:** Request changes resolved — remaining items are non-blocking (Gson JSON bodies, OSS doc property vs header wording, optional integration tests). All 33 unit tests still passing locally. _AI-generated comment on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
