atiaomar1978-hub commented on code in PR #25433:
URL: https://github.com/apache/camel/pull/25433#discussion_r3768032349


##########
components/camel-alibaba/camel-alibaba-mns/src/main/java/org/apache/camel/component/alibaba/mns/MNSEndpoint.java:
##########
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.alibaba.mns;
+
+import com.aliyun.mns.client.MNSClient;
+import org.apache.camel.Category;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.alibaba.common.models.ServiceKeys;
+import org.apache.camel.component.alibaba.mns.constants.MNSHeaders;
+import org.apache.camel.component.alibaba.mns.constants.MNSOperations;
+import org.apache.camel.spi.Metadata;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.spi.UriPath;
+import org.apache.camel.support.ScheduledPollEndpoint;
+
+/**
+ * Send and receive messages to/from Alibaba Cloud Message Service (MNS).
+ */
+@UriEndpoint(firstVersion = "4.23.0", scheme = "alibaba-mns", title = "Alibaba 
Message Service (MNS)",
+             syntax = "alibaba-mns:queueName", category = { Category.CLOUD, 
Category.MESSAGING },
+             headersClass = MNSHeaders.class)
+public class MNSEndpoint extends ScheduledPollEndpoint {
+
+    @UriPath(description = "Queue name, or topic name when using the topic URI 
syntax", displayName = "Queue Name")
+    @Metadata(required = true)
+    private String queueName;
+
+    @UriParam(description = "Operation to perform", displayName = "Operation",
+              enums = 
"sendMessage,receiveMessage,deleteMessage,publishMessage")
+    private String operation;
+
+    @UriParam(description = "Alibaba Cloud region", displayName = "Region")
+    @Metadata(required = true)
+    private String region;
+
+    @UriParam(description = "MNS account endpoint, for example 
https://123456.mns.cn-hangzhou.aliyuncs.com";,
+              displayName = "Account Endpoint")
+    @Metadata(required = true)
+    private String accountEndpoint;
+
+    @UriParam(description = "Access key for the cloud user", displayName = 
"Access Key", secret = true)
+    private String accessKey;
+
+    @UriParam(description = "Secret key for the cloud user", displayName = 
"Secret Key", secret = true)
+    private String secretKey;
+
+    @UriParam(description = "Configuration object for cloud service 
authentication", displayName = "Service Keys",
+              security = "secret")
+    private ServiceKeys serviceKeys;

Review Comment:
   Fixed in `eb936edc` — MNS credentials now match OSS: `accessKey`, 
`secretKey`, and `serviceKeys` all use `secret = true`, `security = "secret"`, 
and `label = "security"`.
   
   _AI-generated reply on behalf of atiaomar1978-hub_



##########
components/camel-alibaba/camel-alibaba-mns/src/main/java/org/apache/camel/component/alibaba/mns/constants/MNSProperties.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.alibaba.mns.constants;
+
+public final class MNSProperties {
+
+    public static final String OPERATION = "CamelAlibabaMnsOperation";
+    public static final String QUEUE_NAME = "CamelAlibabaMnsQueueName";
+    public static final String TOPIC_NAME = "CamelAlibabaMnsTopicName";
+    public static final String RECEIPT_HANDLE = "CamelAlibabaMnsReceiptHandle";
+
+    public static final String MESSAGE_ID = "CamelAlibabaMnsMessageId";
+    public static final String REQUEST_ID = "CamelAlibabaMnsRequestId";

Review Comment:
   Fixed in `eb936edc` — removed `RECEIPT_HANDLE`, `MESSAGE_ID`, and 
`MESSAGE_BODY_MD5` from `MNSProperties`. `MNSUtils.resolveReceiptHandle()` and 
`MNSProducer` now use `MNSHeaders` constants exclusively.
   
   _AI-generated reply on behalf of atiaomar1978-hub_



##########
components/camel-alibaba/camel-alibaba-oss/src/main/java/org/apache/camel/component/alibaba/oss/OSSEndpoint.java:
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.alibaba.oss;
+
+import com.aliyun.sdk.service.oss2.OSSClient;
+import org.apache.camel.Category;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.alibaba.common.models.ServiceKeys;
+import org.apache.camel.component.alibaba.oss.constants.OSSHeaders;
+import org.apache.camel.spi.Metadata;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.spi.UriPath;
+import org.apache.camel.support.ScheduledPollEndpoint;
+
+/**
+ * Alibaba Cloud Object Storage Service (OSS) component
+ */
+@UriEndpoint(firstVersion = "4.23.0", scheme = "alibaba-oss", title = "Alibaba 
Object Storage Service (OSS)",
+             syntax = "alibaba-oss:operation",
+             category = { Category.CLOUD }, headersClass = OSSHeaders.class)

Review Comment:
   Fixed in `eb936edc` — URI syntax is now 
`alibaba-oss:bucketName?operation=putObject&...`. The bucket name is the URI 
path; `operation` is a query parameter. Docs, tests, and catalog metadata 
updated.
   
   _AI-generated reply on behalf of atiaomar1978-hub_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to