JiriOndrusek commented on code in PR #9132:
URL: https://github.com/apache/camel-quarkus/pull/9132#discussion_r3955238721
##########
extensions/ai-tool/deployment/pom.xml:
##########
@@ -38,6 +38,10 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-ai-tool</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
Review Comment:
non-optional quarkus-jackson drags Jackson into every ai-tool app
(extensions/ai-tool/runtime/pom.xml:48-51, plus quarkus-jackson-deployment in
the deployment pom). I verified camel-ai-tool 4.22.0 depends only on
camel-support — no Jackson anywhere. The injected ObjectMapper is used solely
in CamelAiToolProvider.parseArguments(), i.e. only when the bridge is active,
and the bridge can only activate when quarkus-langchain4j-core is present —
which itself has a hard quarkus-jackson dependency (verified in its 1.13.x
pom). So marking quarkus-jackson <optional>true</optional> (and dropping
quarkus-jackson-deployment) is safe in every scenario and keeps the extension
true to its own description, "framework-agnostic".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
